Skip to content

Updated space age tests to properly compare floats#104

Closed
remcopeereboom wants to merge 1 commit intoexercism:masterfrom
remcopeereboom:fixing_space_age_tests
Closed

Updated space age tests to properly compare floats#104
remcopeereboom wants to merge 1 commit intoexercism:masterfrom
remcopeereboom:fixing_space_age_tests

Conversation

@remcopeereboom
Copy link
Copy Markdown
Contributor

The tests originally used assert_equal. Changed them to assert_delta_in
where appropriate.

The tests originally used assert_equal. Changed them to assert_delta_in
where appropriate.
@kytrinyx
Copy link
Copy Markdown
Member

Hi, thanks so much for this. I just accepted a PR from @monkbroc that made the same change (see #103)

I agree completely that this is better ❤️

@kytrinyx kytrinyx closed this Mar 28, 2015
@monkbroc
Copy link
Copy Markdown
Contributor

We discussed this together in this exercise but both
went ahead with a pull request...
On Mar 28, 2015 1:00 AM, "Katrina Owen" notifications@github.com wrote:

Hi, thanks so much for this. I just accepted a PR from @monkbroc
https://github.com/monkbroc that made the same change (see #103
#103)

I agree completely that this is better [image: ❤️]


Reply to this email directly or view it on GitHub
#104 (comment).

@kytrinyx
Copy link
Copy Markdown
Member

Race condition :)

Thanks to you both!

@remcopeereboom remcopeereboom deleted the fixing_space_age_tests branch April 6, 2015 20:01
gchan pushed a commit to gchan/xruby that referenced this pull request Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants