generate run-length-encoding#288
generate run-length-encoding#288kotp merged 3 commits intoexercism:masterfrom Cohen-Carlisle:generate-run-length-encoding
Conversation
|
Try the tool in bin to set the executable bit. Let me know if it doesn't do the right thing. |
Working on this.
Any thoughts on this?
Addressed by #289 |
|
Something seems incorrectly configured... had a similar issue on my pre-push checks... they are not finding Other than that, any thoughts on where this test should live in the track/config.json? |
|
You are missing the last part of the file name you are wanting to require... |
|
Updated. |
|
Generally speaking 'do' is one of the (around 42) reserved bare words in Ruby. Should we be in the habit of using it? |
|
Yeah, that is probably a bad idea. |
|
The 80 is a guide, of course. I also am not sure which line, your link is not helpful as for some reason it did not highlight the line as I thought it would. I noticed there are other files that define a method do. Hamming is used as the example currently for those that want to work on creating the generators. I think it is the wrong thing to do (no pun intended.). Until I understand the generators a little bit better, though, I have no alternative suggestion. |
|
Now that I have a little better understanding, I am using 'actual' in place of 'do'. @kytrinyx I think that is a better representation of what we want to communicate. It may also help with the stroop effect of being in ERB at that level. |
|
And now that it is all together, I am using something else. :) But I did avoid 'do' as a method name. And made the |
|
More and hopefully final changes. |
|
Looks good to me, version numbers are right, reads well, etc. Thanks @Cohen-Carlisle! |
rectangles: Add JSON test data
TODO: implement #decode in example.rb
find place in config.json
why isn't execution bit set on generated tests?