Generated Custom Set II#388
Closed
Cohen-Carlisle wants to merge 3 commits intoexercism:masterfrom
Cohen-Carlisle:348_Shrink_and_cleanupcustom_set.json_common_232
Closed
Generated Custom Set II#388Cohen-Carlisle wants to merge 3 commits intoexercism:masterfrom Cohen-Carlisle:348_Shrink_and_cleanupcustom_set.json_common_232
Cohen-Carlisle wants to merge 3 commits intoexercism:masterfrom
Cohen-Carlisle:348_Shrink_and_cleanupcustom_set.json_common_232
Conversation
The custom-set exercise is generated using data from x-common repository. fixes #365 fixes #348 references exercism/problem-specifications#257
Use #include? over #member? as #include? is more idiomatic. For example, while Enumerable defines both, Array only implements #include? in a more efficient manner.
Contributor
|
Is this still relevant? |
Member
|
Parts are, but probably easier to close this and reopen when rebase is done and those still pieces are reconstructed. This will also open it up for someone else that has time to do so, if they want to tackle the improvements. |
Contributor
|
Closed due to unresolved conflicts after #383 was merged. |
Cohen-Carlisle
deleted the
348_Shrink_and_cleanupcustom_set.json_common_232
branch
gchan
pushed a commit
to gchan/xruby
that referenced
this pull request
Oct 18, 2016
After exercism#332 was created but before it was merged, exercism#351 was created and merged moving all exercises to a new structure. The nth-prime JSON file should now be moved to its place in the new structure as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on the work in #383. Not sure if it should supersede it or merely function as point for discussion. Since those changes, I have:
member?method toinclude?(673ae9f)asserts andrefutes. (e80522a)