Skip to content

Fix tests and example [list-ops]#420

Merged
Insti merged 1 commit intoexercism:masterfrom
srabuini:fix_list-ops
Aug 22, 2016
Merged

Fix tests and example [list-ops]#420
Insti merged 1 commit intoexercism:masterfrom
srabuini:fix_list-ops

Conversation

@srabuini
Copy link
Copy Markdown
Contributor

Hey,

I've found a couple of inconsistencies here. Some assert should be assert_equal, and fixing that, I've realized that some tests doesn't pass anymore. So I'm proposing those changes.

Please have a look and let me know.

Thanks!

@Cohen-Carlisle
Copy link
Copy Markdown
Member

That stuff was definitely pretty broken 😨
Thanks, @srabuini, these changes look good to me.

@Insti
Copy link
Copy Markdown
Contributor

Insti commented Aug 22, 2016

Who merged this? Oh, it was me 😢
Why did I do that? I was cleaning up abandoned pull requests, and this one looked like it had enough work on it that just rejecting it would be a waste.

I wrote:

Does anyone want to address the issues raised by @bernardoamc's last review?
If not I suggest we should just merge it and have a less-than-perfect problem out there for people to try and then suggest improvements to.

Wow, this turned out to be more broken than I expected, but at least my plan worked. Many thanks @srabuini

@Insti Insti merged commit 502cc91 into exercism:master Aug 22, 2016
@Insti
Copy link
Copy Markdown
Contributor

Insti commented Aug 22, 2016

Merging this now due to the brokenness of the original version.
Any tweaks needed can be made in another PR.

@srabuini srabuini deleted the fix_list-ops branch August 22, 2016 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants