Triangle: Update tests to match canonical-data.json.#437
Triangle: Update tests to match canonical-data.json.#437kotp merged 1 commit intoexercism:masterfrom durrellchamorro:master
Conversation
|
@durrellchamorro are you interested in doing the generator for the test so that it can be done once, and regenerated if that json file changes? |
kotp
left a comment
kotp
left a comment
There was a problem hiding this comment.
Quick review, this looks good. Would be even better if it were generated, to keep in line with that json file.
|
I just looked at generator.rb and some of those cases.rb files. It's really neat how you generate the tests this way. I didn't realize that's how it is done and I'm not exactly sure how it all works, so I'll pass on writing the generator for this test. If you don't want to merge this PR, I understand. |
|
It is definitely not that I don't want to merge this in, I just know that it will come back because it is not using that data directly, so this will (eventually) need to be revisited. With that said, the work is done in the form already, and so... it should come in. 👀 @exercism/ruby |
|
If by no one objects, I will consider no objections to merging. |
Insti
changed the title
|
Correct manually created tests are better than incorrect tests. Merge 👍 |
3 participants
As discussed at exercism/problem-specifications#311 and exercism/problem-specifications#375 here are my proposed updates to the tests which reflect the canonical-data.json.