Common generate script#451
Merged
kotp merged 2 commits intoexercism:masterfrom Oct 14, 2016
Merged
Conversation
kotp
reviewed
Oct 11, 2016
Member
kotp
left a comment
kotp
left a comment
There was a problem hiding this comment.
This looks good to me.
How does the contributors documentation need to be changed to communicate this change, if it does, or is it a drop in replacement?
Contributor
|
Nice @bmulvihill, This is something I'd been planning on doing when I found some time, but it looks like you beat me to it. |
Contributor
Author
Member
|
That would be awesome! |
Contributor
Author
kotp
approved these changes
Oct 12, 2016
Insti
approved these changes
Oct 12, 2016
Merged
Member
|
Was blocking #454 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While creating a generator for acronym and noticed how each exercise had it own generate script. This leads to a lot of code duplication since each script is almost identical.
This PR would allow for a single generate script that takes an exercise name as the argument, and regenerates the exercise. If the exercise is not found and error message will display. I tested it out on all the exercises and I had to modify two generators to ensure consistent naming.
Example usage:
bin/generate raindropsLet me know if this is something that would be helpful!