Skip to content

Add tournament#467

Merged
Insti merged 1 commit intoexercism:masterfrom
gchan:tournament
Oct 31, 2016
Merged

Add tournament#467
Insti merged 1 commit intoexercism:masterfrom
gchan:tournament

Conversation

@gchan
Copy link
Copy Markdown
Contributor

@gchan gchan commented Oct 20, 2016

Test generator for the tournament exercise and example solution.

Blithering Badgers | 3 | 1 | 0 | 2 | 3
Courageous Californians | 3 | 0 | 1 | 2 | 1
TALLY
assert_equal expected, actual
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider indenting and trimming the left hand side whitespace.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might work:
expected = <<-TALLY.gsub(/^ */,'')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will only work if there is no internal indentation happening. True in this case, I think.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it works. Updated PR.

Comment thread lib/tournament_cases.rb Outdated
index.zero? ? '# skip' : 'skip'
end

def work_load
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job adhering to the generator interface! Through discussions over the last couple days it was decided to settle on using workload without the underscore.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've renamed the method to workload. For my own reference, is that discussion publicly available somewhere?

Copy link
Copy Markdown
Contributor

@Insti Insti Oct 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The discussion about that can be found here: #463

@gchan gchan force-pushed the tournament branch 2 times, most recently from d0018f4 to ec96d5d Compare October 23, 2016 05:52
Comment thread config.json Outdated
"all-your-base",
"isogram"
"isogram",
"tournament"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'problems' key has been removed from the config.json file, so this now causes a conflict.

@gchan
Copy link
Copy Markdown
Contributor Author

gchan commented Oct 25, 2016

Remove the 'problems' key from config.json and also extracted a indented_heredoc method from tournament_cases.rb

@gchan
Copy link
Copy Markdown
Contributor Author

gchan commented Oct 27, 2016

@Insti @kotp, this one is ready for another review

@kotp kotp added ready and removed in progress labels Oct 28, 2016
@kotp
Copy link
Copy Markdown
Member

kotp commented Oct 28, 2016

Visual read looks good.

@Insti Insti merged commit 0f50983 into exercism:master Oct 31, 2016
@Insti Insti removed the ready label Oct 31, 2016
@Insti
Copy link
Copy Markdown
Contributor

Insti commented Oct 31, 2016

Thanks @gchan ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants