Add phony target for test in Makefile#518
Merged
Insti merged 1 commit intoexercism:masterfrom Dec 29, 2016
Merged
Conversation
Contributor
Author
|
With this change the Travis CI log looks like this: |
Contributor
|
Looks good @tommyschaefer, thanks. I really appreciate the detailed problem description/solution information you include in your PRs ❤️ For reference, documentation for Phony targets in |
Insti
approved these changes
Dec 28, 2016
Contributor
|
Thanks. I didn't notice that I'd broken the tests when I created the I was just glad that the tests of the exercise tests did not run needlessly all the time. So perhaps there is something there that can be improved. Only running the tests of the exercise tests when they have been changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
I noticed while looking at the Travis CI output yesterday that the tests don't appear to be running.
From Travis CI log output:
This is happening because we added a
testdirectory, and the Makefile target is also namedtest.If this looks good to you all and gets merged, I will rebase and push #514, #510, and #509 to run CI with the tests.
Thanks so much for your time!