Run non-exercise tests in CI

[tommyschaefer]

This PR adds rake test to the travis config to run non-exercise tests in CI as discussed in #519.

Resolves #519.

[Insti]

I think we need to first add some magic to not create test coverage files in Travis.

[Insti]

Is this something you can do @tommyschaefer ?

[tommyschaefer]

From the Travis log:

$ rake test
Run options: --seed 21175

# Running:

...................

Fabulous run in 0.009044s, 2100.8717 runs/s, 2432.5883 assertions/s.

19 runs, 22 assertions, 0 failures, 0 errors, 0 skips


The command "rake test" exited with 0.

[Insti]

Clearly the answer was yes. ❤️

[Insti]

This is a separate issue that I noticed while looking through the Travis log:

Use assert_nil if expecting nil from /tmp/all-your-base.FzoC9cwNdy/all_your_base_test.rb:280:in `test_second_base_is_negative'. This will fail in MT6

Are these still the old tests? Is this an issue in the new ones?

[tommyschaefer]

Are these still the old tests? Is this an issue in the new ones?

Yes, this is a warning from the old tests. The new tests generated in #510 don't have this issue.

The old tests use assert_equal nil, ... rather than assert_nil ... which causes the warnings, but the new tests never expect nil since it's actually an error case. Now we expect to raise an argument error.

[Insti]

FWIW: This is a situation where I would have recommended NOT squashing the commits, as adding the rake command to the travis config and altering the test_helper.rb are two separate actions.

It doesn't matter too much here, but it's perhaps a little lesson that squashing is not ALWAYS the thing to do.

[tommyschaefer]

Ah! Good point! Thank you for the feedback!

[kotp]

You can still separate them out, if you wanted to in this PR. But yes, no worries.