bin/generator: Remove version compensation.#538
Closed
Insti wants to merge 2 commits intoexercism:masterfrom
Closed
bin/generator: Remove version compensation.#538Insti wants to merge 2 commits intoexercism:masterfrom
Insti wants to merge 2 commits intoexercism:masterfrom
Conversation
The responsibility for maintaining the template version belongs with the generator, not the template.
Once the templates have been updated, we no longer need to compensate for their version incrementing.
Contributor
Author
|
Superseded by: #540 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the test templates were updating the version:
But the responsibility for mainlining the template version belongs with the generator, not the template.
So we update the template to use the version passed to it:
And once the templates have been updated, we can delete the code required to compensate for the version incrementing.