Test Fixnum#underscore#652
Merged
kotp merged 2 commits intoexercism:masterfrom May 21, 2017
Merged
Conversation
kotp
reviewed
May 21, 2017
| end | ||
|
|
||
| def test_fixnum_underscore | ||
| assert_equal '1_000_000', 1_000_000.underscore |
Member
There was a problem hiding this comment.
The tests should test from a "raw" number, such as 1000000 rather than one with underscores, otherwise why would the call be needed? (Yes, it is needed to also convert it to a string... but this is not clear in the name, especially since the number already has underscores that it is being called on.)
Remove underscores from the Fixnum representation of the number we're testing the underscoring of. This is unnecessary since 1_000_000 == 1000000 and 1_000_000.to_s = "1000000" but it helps to illustrate the purpose of the method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#583 Added a refinement to
Fixnumto convert integers into their underscored string representation.This PR adds a unit test to bring us back up to 100% test coverage.