Skip to content

Fix pangram test for duplicate mixed-case char #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Insti merged 1 commit into from
Aug 28, 2017
Merged

Fix pangram test for duplicate mixed-case char #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exercises/pangram/.meta/.version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4
5
2 changes: 1 addition & 1 deletion exercises/pangram/.meta/solutions/pangram.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module BookKeeping
VERSION = 4
VERSION = 5
end

class Pangram
Expand Down
6 changes: 3 additions & 3 deletions exercises/pangram/pangram_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require 'minitest/autorun'
require_relative 'pangram'

# Common test data version: 1.0.0 f375051
# Common test data version: 1.1.0 fba1aef
class PangramTest < Minitest::Test
def test_sentence_empty
# skip
Expand Down Expand Up @@ -61,7 +61,7 @@ def test_pangram_with_mixed_case_and_punctuation

def test_upper_and_lower_case_versions_of_the_same_character_should_not_be_counted_separately
skip
phrase = 'the quick brown fox jumped over the lazy FOX'
phrase = 'the quick brown fox jumps over with lazy FX'
result = Pangram.pangram?(phrase)
refute result, "Expected false, got: #{result.inspect}. #{phrase.inspect} is NOT a pangram"
end
Expand All @@ -85,6 +85,6 @@ def test_upper_and_lower_case_versions_of_the_same_character_should_not_be_count

def test_bookkeeping
skip
assert_equal 4, BookKeeping::VERSION
assert_equal 5, BookKeeping::VERSION
end
end