Skip to content

Add solution to Two Fer.#719

Closed
ghost wants to merge 8 commits intomasterfrom
unknown repository
Closed

Add solution to Two Fer.#719
ghost wants to merge 8 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Sep 8, 2017

Why?

Solve unimplemented Two Fer problem for Ruby.

What?

Two Fer problem description: https://github.com/exercism/problem-specifications/blob/master/exercises/two-fer/description.md

How Has This Been Tested?

rake test
rake test:two-fer

Types of changes

  • Add Two Fer solution
  • Add Two Fer test case
  • Update config.json

Comment thread config.json Outdated
"topics": [

]
},
Copy link
Copy Markdown
Contributor

@Insti Insti Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put new exercises at the end of the list.

Is this difficulty assessment accurate? Edit: difficulty 1 is right for this problem.

Please add some topics.

Comment thread exercises/two-fer/README.md Outdated

In order to run the test, you can run the test file from the exercise
directory. For example, if the test suite is called
`hello_world_test.rb`, you can run the following command:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can include the actual instructions.

@Insti
Copy link
Copy Markdown
Contributor

Insti commented Sep 8, 2017

Thanks @rudresh4 this is a great start.

I'd like to see a test generator added which would automatically generate the tests based on the common test data. See the instructions about this in the README. The generator for this problem should not be difficult to implement.

@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 8, 2017

@Insti Updates made as requested.

@Insti
Copy link
Copy Markdown
Contributor

Insti commented Sep 8, 2017

Awesome ❤️ thanks.
Can you also commit the generator please?

Comment thread exercises/two-fer/.meta/.version Outdated
@@ -0,0 +1 @@
3 No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the version back to 1.

To do this, locally change this number to 0 then re-generate the tests, which should update it to 1 everywhere.

Comment thread exercises/two-fer/README.md Outdated

In order to run the test, you can run the test file from the exercise
directory. For example, if the test suite is called
`two_fer_test.rb`, you can run the following command:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, if the test suite is called two_fer_test.rb, you can run the following command:

Can probably all be deleted.

@Insti
Copy link
Copy Markdown
Contributor

Insti commented Sep 8, 2017

Looking good we're almost there 👍

@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 8, 2017

@Insti All updates are made based on request

Comment thread exercises/two-fer/README.md Outdated
For installation and learning resources, refer to the
[exercism help page](http://exercism.io/languages/ruby).

For running the tests provided, you will need the Minitest gem. Open a
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section on how to run the tests is required, it was just the "For example.." line that I thought needed to be removed.

Sorry if my earlier request was confusing.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I solved this problem once and for all by autogenerating READMEs: #721

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the testing instructions will need to be part of the README in this PR though.

@ghost ghost closed this Sep 10, 2017
@Insti
Copy link
Copy Markdown
Contributor

Insti commented Sep 10, 2017

@rudresh4 why did you close all your PRs? 😞

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant