Skip to content

Add solution to Sublist problem.#720

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

Add solution to Sublist problem.#720
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Sep 9, 2017

Why?

Solve unimplemented Sublist problem for Ruby.

What?

Sublist problem description: https://github.com/exercism/problem-specifications/blob/master/exercises/sublist/description.md

How Has This Been Tested?

rake test
rake test:sublist

Types of changes

  • Add Sublist solution
  • Add Sublist test case
  • Add Sublist generator
  • Add Sublist README
  • Update config.json


For installation and learning resources, refer to the
[exercism help page](http://exercism.io/languages/ruby).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also include instructions about how to run the tests.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I solved this problem once and for all by autogenerating READMEs: #721

@Insti
Copy link
Copy Markdown
Contributor

Insti commented Sep 9, 2017

This is a great PR, thanks.
It includes everything we need.

I love that you included a link to the canonical data 👍

I'd like us to implement this problem in a property based manner, see: exercism/problem-specifications#424 for how it was done with triangles.
This might be able to be done without a change to the canonical data.

@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 9, 2017

I'd rather have the changes made to canonical data rather than make workarounds for it.

@Insti
Copy link
Copy Markdown
Contributor

Insti commented Sep 9, 2017

In which case we'll need to submit an issue/PR to the https://github.com/exercism/problem-specifications repository about that.

@ghost ghost closed this Sep 10, 2017
@ghost ghost deleted the sublist branch September 10, 2017 05:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant