bob: Update bob to latest canonical data#809
Merged
kotp merged 2 commits intoexercism:masterfrom May 14, 2018
Merged
Conversation
SamKopec
force-pushed
the
normalize_bob
branch
2 times, most recently
from
446802a to
3429af7
Compare
the generator was using a hash instead a string for the remark. This pulls the string out of the hash
SamKopec
force-pushed
the
normalize_bob
branch
2 times, most recently
from
94880ca to
8b476f0
Compare
the exercise changed for shouted questions, this fixes both the test suite and the readme
kytrinyx
approved these changes
May 14, 2018
Member
kytrinyx
left a comment
kytrinyx
left a comment
There was a problem hiding this comment.
This looks good to me ❤️ Thanks @Nadrioc
I'm going to leave this for the Ruby track maintainers to review and merge 🎉
| indent_lines(["remark = #{input.inspect}", | ||
| "assert_equal '#{expected}', Bob.hey(remark), %q{Bob hears #{input.inspect}, and..}" | ||
| indent_lines(["remark = #{input["heyBob"].inspect}", | ||
| "assert_equal #{expected.inspect}, Bob.hey(remark), %q{Bob hears #{input["heyBob"].inspect}, and..}" |
Member
There was a problem hiding this comment.
💯 for using inspect to automatically handle the quoting correctly on the expected value.
Member
|
Thanks @Nadrioc
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit fixes the bob generator to match the latest JSON structure. The second commit regenerates the exercise and readme
closes: #791