React#923
Closed
petertseng wants to merge 2 commits intoexercism:masterfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I once wrote some potential code that could have formed the tests and example solution of the React exercise.
However, it is uncertain that I will have time to complete them sufficiently in the coming months. Thus, I'm doing a dump-and-run and closing this PR immediately after I submit it. A person seeking to port react to the track can freely choose to use any or none of this code, or any amount in between.
The tests are up to date with 2.0.0 of https://github.com/exercism/problem-specifications/blob/master/exercises/react/canonical-data.json . I did not supply a generator because I lacked the perseverance for that project. I believe a generator is technically possible, but not necessarily a prerequisite for getting this exercise on the track.
The remaining steps that would be needed before this is ready:
In addition, I suggest the following:
set_valuerust#434 would be appropriate. Specifically, that would be an interface likecallback.assert_called_with 3andcallback.assert_not_called(orcallback.refute_calledif desired)