DO NOT MERGE: warnings#109
Closed
petertseng wants to merge 4 commits intoexercism:masterfrom
petertseng:DO-NOT-MERGE-warnings
Closed
DO NOT MERGE: warnings#109petertseng wants to merge 4 commits intoexercism:masterfrom petertseng:DO-NOT-MERGE-warnings
petertseng wants to merge 4 commits intoexercism:masterfrom
petertseng:DO-NOT-MERGE-warnings
Conversation
| if [ $status -ne 0 ]; then | ||
| # Instead of immediate exit, we keep going. | ||
| # This allows us to see all warnings. | ||
| exitcode=1 |
Member
Author
There was a problem hiding this comment.
hmm, isn't actually causing exit. wonder why.
Member
Author
There was a problem hiding this comment.
subshells can't affect their parent shell's vars, of course. have to return it.
I don't intend to be terribly strict on warnings (so as to actually fail a build with them) but I think I'd like a way to see them, so I'll let Travis do the job. This is motivated by the fact that I introduced warnings in #81 and they were not caught.
This requires not setting -e for the `cargo test` run, nor exiting early in the manual status check. The motivation is that we'd like to see all warnings in this mode, not just the first exercise with warnings.
In DENYWARNINGS I just want to see all the warnings; I don't care about whether the tests actually pass or what I'm compiling or downloading.
This tests whether multiple warnings are showing up.
| @@ -1,3 +1,5 @@ | |||
| use std::convert::AsRef; | |||
Member
Author
There was a problem hiding this comment.
as luck would have it, this is not a warning. word_count has a legitimate use of as_ref. Doesn't matter, I've seen what I need to see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging ground to test some refinements to #107 as well as intentionally adding some warnings to test whether the changes are working as expected. Do not merge.