Hamming: Make error checking identical to other tests#169
Merged
IanWhitney merged 1 commit intoexercism:masterfrom Jul 13, 2016
jonasbb:hamming-test
Merged
Hamming: Make error checking identical to other tests#169IanWhitney merged 1 commit intoexercism:masterfrom jonasbb:hamming-test
IanWhitney merged 1 commit intoexercism:masterfrom
jonasbb:hamming-test
Conversation
Contributor
|
Thanks. I like it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this after @petertseng mentioned the error handling in #147.
The Hamming exercise performs error checking with comparison to
Err(.). Most tests (Nucleotide Codons, Queen Attack, Wordy) only check withis_err(). The exceptions are Circular Buffer and Forth, but they use more complex error reporting with different conditions and provide anErrorenum with the correct return values.Because there is only one error conditions I suggest to remove the fixed value and only check with
is_err().