react: example: Check all dependents to avoid partial write#203
Merged
petertseng merged 2 commits intoexercism:masterfrom Sep 17, 2016
petertseng:react
Merged
react: example: Check all dependents to avoid partial write#203petertseng merged 2 commits intoexercism:masterfrom petertseng:react
petertseng merged 2 commits intoexercism:masterfrom
petertseng:react
Conversation
Member
Author
|
I could write a test to deal with this, but this is quite an implementation detail. I will add the test and see what reviewers think. |
Member
Author
|
Test added. Example solution fails the attached test unless it has the attached code change. It's not guaranteed that this will catch every single implementation that incorrectly does partial writes, but it's the best I can do, I think. In case you wonder, this test doesn't seem necesary to add to exercism/problem-specifications#358 because most other tracks don't have to deal with cell IDs like we do; they can just have the cells reference each other (we didn't do that in Rust because mutual references are tricky). |
IanWhitney
approved these changes
Sep 17, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #202