Bug fix for the last test of Allergies#209
Bug fix for the last test of Allergies#209k0pernicus wants to merge 1 commit intoexercism:masterfrom
Allergies#209Conversation
The last test must not contains false positives, but 509 is greater than 255 so `expected` must contain `Allergen::Peanuts`.
|
I think the test is correct as-is - 509 & 255 is 253, so the result for 509 should be the same as the result for 253, and the result for 253 does not contain Peanuts Edit: correction in my comment: 253 instead of 252. |
|
This test is present in the Rust track because it is present in the common test data at https://github.com/exercism/x-common/blob/master/exercises/allergies/canonical-data.json - if we wish to change it, it is best to change it there so that all tracks can update their tests A discussion for numbers > 255 is at exercism/problem-specifications#224 |
|
Ok so write directly in the README file that if the numbers is greater than 255, you have to make a I think it exists a better solution to this end, returning a |
|
Yes, we should discuss at exercism/problem-specifications#224 whether the correct solution is to |
|
I suggest we close this until exercism/problem-specifications#224 is resolved |
The last test must not contains false positives, but 509 is greater than 255 so
expectedmust containAllergen::Peanuts.