assert that eval() returns ok where it should#296
Merged
petertseng merged 1 commit intoexercism:masterfrom May 30, 2017
Merged
Conversation
Member
|
I think I'm for this. I would like to see the |
This detects failed attempts where the stack looks as expected but eval still returns the wrong result. Also, this should point out some implementation errors more clearly because you see a specific error result and not just the mismatching stack content. Especially when there are multiple eval() calls in a row.
da13d03 to
c7f395c
Compare
Contributor
Author
|
Good point. The first line with that warning suppressing attribute is gone now. (And, as expected, because of the new asserts no warnings are emitted.) |
petertseng
approved these changes
May 30, 2017
Member
petertseng
left a comment
There was a problem hiding this comment.
Thanks. I am for this and I agree with the reasoning.
Once 48 hours have passed since it was first opened (<12 hours from now) I'll merge if nobody else has any else to say.
It is interesting that we did not use the same reasoning in bowling (#213). Should we?
ijanos
approved these changes
May 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This detects failed attempts where the stack looks as expected but
eval still returns the wrong result.
Also, this should point out some implementation errors more clearly
because you see a specific error result and not just the mismatching
stack content. Especially when there are multiple eval() calls in a row.