Standardize proverb tests#380
Merged
coriolinus merged 1 commit intoexercism:masterfrom Nov 3, 2017
Merged
Conversation
Closes exercism#379. - Eliminate the inconsistencies pointed out in exercism#379. - Add a new test with different vocab to reduce the viability of hard-coded solutions - Update example implementation to correctly handle the new tests This should not break existing solutions, because users who have already completed the exercise won't be prompted to re-try it. It simply makes the exercise more rational for future users.
petertseng
approved these changes
Nov 3, 2017
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
sure, I'm down with this. Since there is no canonical-data.json, by definition we cannot be wrong, so there is no fear in making any change.
coriolinus
added a commit
to exercism/problem-specifications
that referenced
this pull request
Nov 3, 2017
This is based on the Rust tests as implemented in exercism/rust#380. The lack of canonical data had resulted in odd custom tests being designed, which was reported in exercism/rust#379.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #379.
This should not break existing solutions, because users who have already
completed the exercise won't be prompted to re-try it. It simply makes
the exercise more rational for future users.