Remove unused variable from Alphametics stub#388
Merged
coriolinus merged 1 commit intoexercism:masterfrom Nov 7, 2017
Merged
Conversation
ijanos
approved these changes
Nov 7, 2017
Member
Member
Author
|
I need to update #381. Your comment about the deny warnings insertion
script line makes sense, which means that I did introduce an unintentional
change in behavior there.
…On Wed, Nov 8, 2017 at 1:16 AM, Peter Tseng ***@***.***> wrote:
I support this change.
I strongly believe this is not the reason #381
<#381> fails, if #381
<#381> preserved existing behaviour.
Stubs are never compiled with [deny(warnings)] in current tests. If #381
<#381> fails, then #381
<#381> did not preserve that
behaviour and instead represents a change in behaviour.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#388 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHdeTj1OtMrdozHEUvd7YunDxeae1cpQks5s0PLggaJpZM4QUna7>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis fails in general right now, because we have an unused variable in the Alphametics stub. This is causing #381 to fail right now, and possibly others.
This simply removes the unused name from the Alphametics stub. This changes no interfaces or tests; students may rename the variable to anything they prefer. It simply ensures that the
_test/ensure-stubs-compile.shtest actually passes.