bob 1.1.0: Add yelling question rule#418
Merged
petertseng merged 1 commit intoexercism:masterfrom Dec 18, 2017
petertseng:bo
Merged
bob 1.1.0: Add yelling question rule#418petertseng merged 1 commit intoexercism:masterfrom petertseng:bo
petertseng merged 1 commit intoexercism:masterfrom
petertseng:bo
Conversation
Closes exercism/problem-specifications#943. It was possible for a message directed to Bob to be both a question and yelling, which meant it was unclear which rule should take effect. Resolve ambiguity by simply adding a rule for that case. exercism/problem-specifications#1025
Member
Author
|
Oh just great. I typo'd the branch name. Oh well, too late to do anything about it now. |
coriolinus
approved these changes
Dec 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes exercism/problem-specifications#943.
It was possible for a message directed to Bob to be both a question and
yelling, which meant it was unclear which rule should take effect.
Resolve ambiguity by simply adding a rule for that case.
exercism/problem-specifications#1025