prime-factors: Add solution template

[nathanielknight]

No description provided.

[coriolinus]

Hi @neganp, thanks for this PR! It generally looks good, but I'd like you to make the change shown below so that there are no compile warnings when the student first downloads the exercise.

[coriolinus]

Please update to reference n so that there is no unused variable warning, like this.

[nathanielknight]

Oh nice! I didn't know you could do that. 👍

[coriolinus]

Looks good, thanks!

I'm going to let this sit for a few days now so other maintainers have a chance to take a look and make their comments, but unless blocking changes are discovered, I intend to merge this on 5 Mar.

[nathanielknight]

Cool, thanks! 🙂

[petertseng]

Yes.

I recommend squash when merging.

You have reminded me (or this PR caused me to remind myself, whichever wording you think is better) that in #269 we decided that all exercises should have stubs that allow running the tests, got it.

[pravic]

@neganp Have you reviewed your code? The test uses a big number which does not fit into u32:

rust/exercises/prime-factors/tests/prime-factors.rs

Lines 42 to 44 in 80d2988

	fn test_factors_include_large_prime() {
	assert_eq!(factors(93819012551), vec![11, 9539, 894119]);
	}

[nathanielknight]

Oh, good catch. Weird that it passed all my tests 😕

It looks like a u64 is big enough on my platform. Would that work?

[nathanielknight]

Wait, this doesn't even pass my tests; how embarrassing 😧 .

[coriolinus]

This raises the question: why didn't Travis catch this?

…

On Wed, Mar 14, 2018, 17:52 Nathaniel Knight ***@***.***> wrote: Wait, this doesn't even pass my tests; how embarrassing 😧 . — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#440 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHdeTn5GVw1-1ND0N1thd7zykJtowT4Wks5teUrJgaJpZM4SVr-d> .

[nathanielknight]

I looks like some of the tests don't run on at least some of the builds: https://travis-ci.org/exercism/rust/jobs/347483074#L2213

[coriolinus]

I think that's a bug which we should fix.