custom-set: allow example's new to take iterator#456
Closed
petertseng wants to merge 2 commits intoexercism:masterfrom
petertseng:custom-set-short
Closed
custom-set: allow example's new to take iterator#456petertseng wants to merge 2 commits intoexercism:masterfrom petertseng:custom-set-short
new to take iterator#456petertseng wants to merge 2 commits intoexercism:masterfrom
petertseng:custom-set-short
Conversation
I don't believe Clippy gave a suggestion for this one, but it is similar to useless_vec. The example had to be reworked to make this work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the first commit is something we want? We'd like CustomSet to take
&[T]instead ofVec<T>, right? It is included in #454 so that's fineThe second commit ("custom-set:take the iterator directly") is interesting but doesn't appear to have any other tangible benefits. I don't think I'm inclined to merge it.
Note that this only adds functionality to the example; student solutions are not required to take an IntoIterator.