Replace first edition Rust book links with second edition#491
Merged
coriolinus merged 3 commits intoexercism:masterfrom Apr 8, 2018
petertseng:book
Merged
Replace first edition Rust book links with second edition#491coriolinus merged 3 commits intoexercism:masterfrom petertseng:book
coriolinus merged 3 commits intoexercism:masterfrom
petertseng:book
Conversation
The goal was to explain that you can derive some traits. The Derivable Traits section of the book also serves this purpose, as it explains that `derive` automatically implements a trait, and enumerates the traits that you can derive. Note that https://doc.rust-lang.org/book/traits.html#deriving only links to two pages which don't seem like the best choice for this: * https://doc.rust-lang.org/book/second-edition/ch10-02-traits.html * https://doc.rust-lang.org/book/second-edition/ch19-03-advanced-traits.html Alternative to consider: Rust By Example (now a part of doc.rust-lang.org as of 1.25). https://doc.rust-lang.org/rust-by-example/trait/derive.html We'll choose the book unless there is a strong reason to choose another. Part of #356
Visiting https://doc.rust-lang.org/book/macros.html leads to the suggestions: * https://doc.rust-lang.org/reference/macros-by-example.html * https://doc.rust-lang.org/book/second-edition/appendix-04-macros.html In addition, we may consider Rust By Example (now a part of the docs as of 1.25): https://doc.rust-lang.org/rust-by-example/macros.html We'll choose the book unless there is a strong reason to prefer another. Part of #356
https://doc.rust-lang.org/book/release-channels.html shows the following suggestions: * https://github.com/rust-lang-nursery/rustup.rs/blob/master/README.md#keeping-rust-up-to-date * https://www.rust-lang.org/en-US/install.html * https://github.com/rust-lang/rfcs/blob/master/text/0507-release-channels.md * https://doc.rust-lang.org/book/second-edition/ch01-03-how-rust-is-made-and-nightly-rust.html Of these, the second edition seems to most fit the purpose here: Explain the channels and how to use Nightly. The Rustup documentation is already being linked to. Part of #356
coriolinus
approved these changes
Apr 8, 2018
ijanos
approved these changes
Apr 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think all first edition chapters have second edition equivalents. Rationale in individual commit messages.
If all additions are accepted, these three commits collectively close #356.