Adds stub definition to the ETL exercise#550
Merged
coriolinus merged 2 commits intoexercism:masterfrom Jun 22, 2018
Merged
Conversation
coriolinus
reviewed
Jun 18, 2018
| use std::collections::BTreeMap; | ||
|
|
||
| pub fn transform(h: &BTreeMap<i32, Vec<char>>) -> BTreeMap<char, i32> { | ||
| unimplemented!("How will you transform the tree {:?}?", h) |
Member
There was a problem hiding this comment.
Please express this in the form of an imperative statement: "Transform this tree: {:?}" or similar.
coriolinus
approved these changes
Jun 18, 2018
Member
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
Thanks @tushartyagi for this PR! It looks good to me.
I've requested one change, but it is optional.
I'm going to leave this for a while to ensure other maintainers have a chance to see it. Assuming there are no objections, I intend to merge this on Friday the 22nd. If on Saturday I still have not done so, please feel free to ping me a reminder.
ijanos
approved these changes
Jun 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lib.rsfile of ETL exercise is missing the function stub. Adding it in this commit.