nucleotide-count: Added template to stub file#565
Merged
coriolinus merged 3 commits intoexercism:masterfrom Jul 6, 2018
Merged
nucleotide-count: Added template to stub file#565coriolinus merged 3 commits intoexercism:masterfrom
coriolinus merged 3 commits intoexercism:masterfrom
Conversation
coriolinus
suggested changes
Jul 3, 2018
Member
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
Thanks @ZapAnton, this generally looks good. I've marked where I want a change, but this is nearly complete as a stub insertion.
Optionally, if you're willing, it would be great if you could also update the associated tests to ensure that the error value is the first invalid char in the input string.
| @@ -1 +1,16 @@ | |||
| use std::collections::HashMap; | |||
|
|
|||
| pub fn count(nucleotide: char, dna: &str) -> Result<usize, ()> { | |||
Member
There was a problem hiding this comment.
For consistency, this should return Result<usize, char>, where the error type is the invalid character.
Contributor
Author
|
Done, @coriolinus |
coriolinus
approved these changes
Jul 4, 2018
Member
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
Thanks, LGTM!
Scheduling this one for Friday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #551.
I guess it also closes #512, since no further comments were made about rewriting returned
Resultor usingOption/panic!