grep: Fixed typo in the README#587
Conversation
coriolinus
left a comment
There was a problem hiding this comment.
I plan to merge this on Wednesday unless someone objects.
No, I cannot agree with that. No matter the size of the change, each change should have its own commit so that if I look at the log I can understand why something changed. I have created #597 . Once it is merged, I request this be rebased so the |
|
Still awaiting that rebase (to be clear, the final state should be that only one commit "grep: Fixed typo in the README" appears in https://github.com/exercism/rust/pull/587/commits instead of 22 commits) |
|
I think i messed this one a bit and now cannot find the right solution. After @coriolinus requested the @coriolinus if you have moment, can you give me a hint about a proper steps to finish this PR? Sorry for the inconvenience. |
|
@ZapAnton I've rebased this for you. This is the sequence of commands I used: git checkout master # exit the branch I had been on
git pull exercism master # update master from exercism
git fetch zapanton # fetch the list of branches you have active
git checkout grep_update # check out this branch
git rebase master # rebase against the most current master
git log --graph --decorate --oneline # demonstrate that there's only one commit past master
git push -f # force-push the branch to update the PR |
|
Thanks. |
Basically applies #578 for the
grepexercise.It seems like
bobwas also updated from the latestproblem-specification.It is a minor change, so maybe it is OK to leave it in this PR?