Skip to content

fix misspellings#656

Merged
coriolinus merged 1 commit intoexercism:masterfrom
AndrewKvalheim:spell-check
Sep 11, 2018
Merged

fix misspellings#656
coriolinus merged 1 commit intoexercism:masterfrom
AndrewKvalheim:spell-check

Conversation

@AndrewKvalheim
Copy link
Copy Markdown
Contributor

Noticed another typo while doing the exercises so I ran a spell check.

Copy link
Copy Markdown
Member

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for doing this!

Because this PR technically changes some code, I'll let it sit for a while in case other maintainers have things to say, but unless someone objects, I'll plan to merge this tomorrow. If in two days I have not yet done so, please feel free to ping me a reminder.

@coriolinus
Copy link
Copy Markdown
Member

I'm very sorry--at the time of my approval yesterday, I hadn't realized that Travis wouldn't pass. I forgot that we also check READMEs; it's my fault for prematurely approving. There are four instances where it found unexpected changes:

  • crypto-square: the README is generated from the problem specifications; we can't merge this while upstream differs. Please either open an issue upstream to fix this or revert this change.
  • dominoes: same issue: the problem is upstream. Please open an issue upstream to fix it or revert this change.
  • simple-cipher: Again, the root problem lies upstream. Please either open an issue upstream or revert this change.
  • luhn-trait: this is a Rust-specific exercise, so we can fix it in this track. In this case, you'll need to also apply the fix to .meta/metadata.yml in order for Travis to approve.

Reversion will happen on your schedule, but isn't ideal. Opening an issue upstream to fix those spelling errors would be preferable, but will take longer. In either case, I won't merge until Travis passes.

I apologize again for approving prematurely.

@AndrewKvalheim
Copy link
Copy Markdown
Contributor Author

Whoops, thanks. The only test I ran was check-exercises.sh.

@coriolinus coriolinus merged commit c2362c3 into exercism:master Sep 11, 2018
@coriolinus
Copy link
Copy Markdown
Member

Thanks @AndrewKvalheim for doing this work, and particularly for following through and writing the upstream PR as well!

@AndrewKvalheim AndrewKvalheim deleted the spell-check branch September 26, 2018 03:59
@petertseng petertseng added the sync/readme Keep a README in sync with exercism/problem-specifications label Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sync/readme Keep a README in sync with exercism/problem-specifications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants