fix misspellings#656
Conversation
coriolinus
left a comment
There was a problem hiding this comment.
Looks great, thanks for doing this!
Because this PR technically changes some code, I'll let it sit for a while in case other maintainers have things to say, but unless someone objects, I'll plan to merge this tomorrow. If in two days I have not yet done so, please feel free to ping me a reminder.
|
I'm very sorry--at the time of my approval yesterday, I hadn't realized that Travis wouldn't pass. I forgot that we also check READMEs; it's my fault for prematurely approving. There are four instances where it found unexpected changes:
Reversion will happen on your schedule, but isn't ideal. Opening an issue upstream to fix those spelling errors would be preferable, but will take longer. In either case, I won't merge until Travis passes. I apologize again for approving prematurely. |
|
Whoops, thanks. The only test I ran was |
0db3e4e to
d183359
Compare
d183359 to
7d3bf70
Compare
|
Thanks @AndrewKvalheim for doing this work, and particularly for following through and writing the upstream PR as well! |
Noticed another typo while doing the exercises so I ran a spell check.