proverb: no-op declare compliance with 1.1.0#738
Merged
petertseng merged 1 commit intoexercism:masterfrom Nov 18, 2018
petertseng:proverb
Merged
proverb: no-op declare compliance with 1.1.0#738petertseng merged 1 commit intoexercism:masterfrom petertseng:proverb
petertseng merged 1 commit intoexercism:masterfrom
petertseng:proverb
Conversation
Actually, the canonical data was born from the Rust implementation. exercism/problem-specifications#994 1.1.0 moves inputs to the `input` object. exercism/problem-specifications#1157 The Rust track has all the canonical tests, although in a different order. Reviewers should indicate whether an ordering change in the Rust tests is desired.
petertseng
added
the
sync/tests
coriolinus
approved these changes
Nov 18, 2018
Member
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
I don't think that the ordering of the tests is very important.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually, the canonical data was born from the Rust implementation.
exercism/problem-specifications#994
1.1.0 moves inputs to the
inputobject.exercism/problem-specifications#1157
The Rust track has all the canonical tests, although in a different
order. Reviewers should indicate whether an ordering change in the Rust
tests is desired.