Fix pythagorean-triplet readme, in accordance to the updated tests#754
Merged
petertseng merged 1 commit intoexercism:masterfrom Nov 20, 2018
Merged
Fix pythagorean-triplet readme, in accordance to the updated tests#754petertseng merged 1 commit intoexercism:masterfrom
petertseng merged 1 commit intoexercism:masterfrom
Conversation
Contributor
Author
|
woops, didn't know that it checks for problem-specifications. closing this and will wait for exercism/problem-specifications#1395 instead 🙏 |
petertseng
added
the
sync/readme
This is as described in exercism/problem-specifications#1395 The current README will really confuse non math-savvy students, as it asked to find `a*b*c`, while the tests actually check for the triplets. Change it to asks for the triplet explicitly. Give the answer for N = 1000 as it's also spoiled in the test file ;)
petertseng
approved these changes
Nov 20, 2018
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
I'd like to have this ASAP, since otherwise the tests do not match the README.
Since it seems to be standard procedure that documentation changes are A-OK to merge speedily as long as tests pass (and tests have now been confirmed to pass for this), I have chosen to merge this now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is as described in exercism/problem-specifications#1395
The current README will really confuse non math-savvy students, as it asked to find
a*b*c, while the tests actually check for the triplets.Change it to asks for the triplet explicitly. Give the answer for N = 1000 as it's also spoiled in the test file ;)