forth: Prepare for 2018 by not using Term and using ? not try!#779
Merged
petertseng merged 2 commits intoexercism:masterfrom Dec 17, 2018
petertseng:forth
Merged
forth: Prepare for 2018 by not using Term and using ? not try!#779petertseng merged 2 commits intoexercism:masterfrom petertseng:forth
Term and using ? not try!#779petertseng merged 2 commits intoexercism:masterfrom
petertseng:forth
Conversation
I prefer to make it easier to see where `term` is being used.
Also, this causes an error in Rust 2018:
error[E0658]: imports can only refer to extern crate names passed with `--extern` on stable channel (see issue #53130)
--> src/lib.rs:5:5
|
5 | use Term::*;
| ^^^^
Of course there are probably other ways to fix that, but not something I
want to do right now.
Would cause an error in Rust 2018:
error: expected expression, found reserved keyword `try`
--> src/lib.rs:72:13
|
72 | try!(self.step_term(term))
| ^^^ expected expression
Member
Author
|
I understand that I could have just done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for #769 .
Blocking #769 and all other otherwise-active maintainers declared inactivity, so I'm merging when tests pass.