matching-brackets: Rename to bracket-push; _test: Exclude deleted files#819
matching-brackets: Rename to bracket-push; _test: Exclude deleted files#819petertseng merged 2 commits intoexercism:masterfrom petertseng:matching-brackets
Conversation
This rename was proposed in: exercism/problem-specifications#1501 The rationale for the name is: * to name the exercise by its story, not by what it potentially teaches * to avoid unnecessarily biasing the solution space
|
I am considering opening a issue for something like "track scripts: correctly handle an exercise being deleted", but until I have evidence that the event will happen with some regularity, I'm not motivated to fix that. |
|
Sounds like a reasonable policy. I suspect that deletion will be pretty
rare, at least compared to deprecation, which is already uncommon.
…On Mon, Apr 15, 2019 at 2:47 PM Peter Tseng ***@***.***> wrote:
I am considering opening a issue for something like "track scripts:
correctly handle an exercise being deleted", but until I have evidence that
the event will happen with some regularity, I'm not motivated to fix that.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#819 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHdeTps2j-RFJDo-YZ_7AHbybLEJmQDrks5vhMkwgaJpZM4cuzP->
.
|
|
I decided to file an issue anyway, and just close it immediately. In the issue I also noted the point that I include exercise rename in the list of operations that involve deletion. In light of the decision, I would say that Travis CI is in as good of a state as it will ever be for this pull request, then. |
A deleted file needs no checks. This allows Travis CI to show useful results (instead of failing) when we rename an exercise, for example. Closes #820
|
Since I think there's a quick win, I've instead executed the change described, and propose it for inclusion. Since it's quite hard to test it without an accompanying delete, I've included it in this PR. In light of this (there are two commits that do completely different things), it should go without saying that these commits absolutely cannot be squashed. |
coriolinus
left a comment
There was a problem hiding this comment.
Nice, I like the test suite upgrade.
This rename was proposed in:
exercism/problem-specifications#1501
The rationale for the name is: