Skip to content

matching-brackets: Rename to bracket-push; _test: Exclude deleted files#819

Merged
petertseng merged 2 commits intoexercism:masterfrom
petertseng:matching-brackets
Apr 16, 2019
Merged

matching-brackets: Rename to bracket-push; _test: Exclude deleted files#819
petertseng merged 2 commits intoexercism:masterfrom
petertseng:matching-brackets

Conversation

@petertseng
Copy link
Copy Markdown
Member

This rename was proposed in:
exercism/problem-specifications#1501

The rationale for the name is:

  • to name the exercise by its story, not by what it potentially teaches
  • to avoid unnecessarily biasing the solution space

@petertseng petertseng changed the title matching-brackets: Rename to bracket-push (#88) matching-brackets: Rename to bracket-push Apr 14, 2019
This rename was proposed in:
exercism/problem-specifications#1501

The rationale for the name is:

* to name the exercise by its story, not by what it potentially teaches
* to avoid unnecessarily biasing the solution space
@petertseng
Copy link
Copy Markdown
Member Author

I am considering opening a issue for something like "track scripts: correctly handle an exercise being deleted", but until I have evidence that the event will happen with some regularity, I'm not motivated to fix that.

@coriolinus
Copy link
Copy Markdown
Member

coriolinus commented Apr 16, 2019 via email

@petertseng
Copy link
Copy Markdown
Member Author

I decided to file an issue anyway, and just close it immediately. In the issue I also noted the point that I include exercise rename in the list of operations that involve deletion.
Perhaps one day we will make a mistake in a rename and that will motivate a closer look at the scripts.

In light of the decision, I would say that Travis CI is in as good of a state as it will ever be for this pull request, then.

A deleted file needs no checks.
This allows Travis CI to show useful results (instead of failing) when
we rename an exercise, for example.

Closes #820
@petertseng petertseng changed the title matching-brackets: Rename to bracket-push matching-brackets: Rename to bracket-push; _test: Exclude deleted files Apr 16, 2019
@petertseng
Copy link
Copy Markdown
Member Author

Since I think there's a quick win, I've instead executed the change described, and propose it for inclusion. Since it's quite hard to test it without an accompanying delete, I've included it in this PR.

In light of this (there are two commits that do completely different things), it should go without saying that these commits absolutely cannot be squashed.

Copy link
Copy Markdown
Member

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the test suite upgrade.

@petertseng petertseng merged commit b0026d7 into exercism:master Apr 16, 2019
@petertseng petertseng deleted the matching-brackets branch April 16, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants