react: Test removing callback from nonexistent cell#868
Merged
coriolinus merged 1 commit intoexercism:masterfrom Sep 9, 2019
Merged
Conversation
RemoveCallbackError::NonexistentCell was not tested yet, add new test. Fixes exercism#465
coriolinus
approved these changes
Sep 7, 2019
Member
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
Looks good! Thanks @jku for adding this test.
I'll leave this a few more days in case there are other maintainer comments, but my intention is to merge this not later than Monday unless there are objections.
petertseng
approved these changes
Sep 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoveCallbackError::NonexistentCell was not tested yet, add new test.
Fixes #465