hello world: make topics match the content#883
Merged
petertseng merged 1 commit intoexercism:masterfrom Oct 5, 2019
Merged
Conversation
This used to be `println` which actually occures nowhere in the excercise. Change this to: * `strings` - because the function returns a string and we compare strings * `test_driven_development` - as this is the first excercise and people learn the red, green flow. Both topics are taken from https://github.com/exercism/problem-specifications/blob/master/TOPICS.txt This also addresses exercism#529 for `hello world`.
petertseng
approved these changes
Oct 4, 2019
Member
petertseng
left a comment
There was a problem hiding this comment.
I am confused as to why println was ever a topic for hello-world. I cannot remember any point in the history of the exercise where println! was used. At the very most, back in the two-fer-equivalent version of hello-world, there would have been format!, but never println. Shrug. The new topics seem much better.
Other maintainers have about 24 hours to object.
ErikSchierboom
pushed a commit
to ErikSchierboom/rust
that referenced
this pull request
Jan 26, 2021
* add enums concept exercise closes exercism#830 * Update languages/exercises/concept/enums/src/lib.rs Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * Update languages/exercises/concept/enums/tests/enums.rs Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * Update languages/exercises/concept/enums/src/lib.rs Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * invert the sense of enums concept exercise * Update languages/exercises/concept/enums/.docs/after.md Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * Update languages/exercises/concept/enums/.meta/design.md Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * Update languages/exercises/concept/enums/.meta/design.md Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * Update languages/exercises/concept/enums/.meta/design.md Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * add description for other variant Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
ErikSchierboom
pushed a commit
to ErikSchierboom/rust
that referenced
this pull request
Jan 27, 2021
* add enums concept exercise closes exercism#830 * Update languages/exercises/concept/enums/src/lib.rs Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * Update languages/exercises/concept/enums/tests/enums.rs Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * Update languages/exercises/concept/enums/src/lib.rs Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * invert the sense of enums concept exercise * Update languages/exercises/concept/enums/.docs/after.md Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * Update languages/exercises/concept/enums/.meta/design.md Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * Update languages/exercises/concept/enums/.meta/design.md Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * Update languages/exercises/concept/enums/.meta/design.md Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * add description for other variant Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This used to be
printlnwhich actually occures nowhere in the excercise.Change this to:
strings- because the function returns a string and we compare stringstest_driven_development- as this is the first excercise and people learn the red, green flow.Both topics are taken from https://github.com/exercism/problem-specifications/blob/master/TOPICS.txt
This also addresses #529 for
hello world.