Skip to content

hello world: make topics match the content#883

Merged
petertseng merged 1 commit intoexercism:masterfrom
azul:patch-1
Oct 5, 2019
Merged

hello world: make topics match the content#883
petertseng merged 1 commit intoexercism:masterfrom
azul:patch-1

Conversation

@azul
Copy link
Copy Markdown
Contributor

@azul azul commented Oct 4, 2019

This used to be println which actually occures nowhere in the excercise.
Change this to:

  • strings - because the function returns a string and we compare strings
  • test_driven_development - as this is the first excercise and people learn the red, green flow.

Both topics are taken from https://github.com/exercism/problem-specifications/blob/master/TOPICS.txt

This also addresses #529 for hello world.

This used to be `println` which actually occures nowhere in the excercise.
Change this to:
* `strings` - because the function returns a string and we compare strings
* `test_driven_development` - as this is the first excercise and people learn the red, green flow.

Both topics are taken from https://github.com/exercism/problem-specifications/blob/master/TOPICS.txt

This also addresses exercism#529 for `hello world`.
Copy link
Copy Markdown
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused as to why println was ever a topic for hello-world. I cannot remember any point in the history of the exercise where println! was used. At the very most, back in the two-fer-equivalent version of hello-world, there would have been format!, but never println. Shrug. The new topics seem much better.

Other maintainers have about 24 hours to object.

@petertseng petertseng merged commit d692508 into exercism:master Oct 5, 2019
@azul azul deleted the patch-1 branch October 5, 2019 08:45
ErikSchierboom pushed a commit to ErikSchierboom/rust that referenced this pull request Jan 26, 2021
* add enums concept exercise

closes exercism#830

* Update languages/exercises/concept/enums/src/lib.rs

Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* Update languages/exercises/concept/enums/tests/enums.rs

Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* Update languages/exercises/concept/enums/src/lib.rs

Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* invert the sense of enums concept exercise

* Update languages/exercises/concept/enums/.docs/after.md

Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* Update languages/exercises/concept/enums/.meta/design.md

Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* Update languages/exercises/concept/enums/.meta/design.md

Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* Update languages/exercises/concept/enums/.meta/design.md

Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* add description for other variant

Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
ErikSchierboom pushed a commit to ErikSchierboom/rust that referenced this pull request Jan 27, 2021
* add enums concept exercise

closes exercism#830

* Update languages/exercises/concept/enums/src/lib.rs

Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* Update languages/exercises/concept/enums/tests/enums.rs

Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* Update languages/exercises/concept/enums/src/lib.rs

Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* invert the sense of enums concept exercise

* Update languages/exercises/concept/enums/.docs/after.md

Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* Update languages/exercises/concept/enums/.meta/design.md

Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* Update languages/exercises/concept/enums/.meta/design.md

Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* Update languages/exercises/concept/enums/.meta/design.md

Co-Authored-By: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>

* add description for other variant

Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants