custom-set: remove Debug trait bound from stub#889
Merged
coriolinus merged 1 commit intoexercism:masterfrom Oct 13, 2019
Merged
custom-set: remove Debug trait bound from stub#889coriolinus merged 1 commit intoexercism:masterfrom
coriolinus merged 1 commit intoexercism:masterfrom
Conversation
Closes exercism#631. Retain Debug derive so assert_eq works.
petertseng
approved these changes
Oct 13, 2019
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
While I don't think it was necessary to remove the unimplemented messages entirely, I don't object, on the basis that these functions are hopefully self-explanatory...
The alternative I was thinking of would be to use an unimplemented message that doesn't mention the element. Such as Determine if the element is present in the set.
I pre-emptively approve as I would be satisfied with any choice made, but feel free to ask if the messages and changed and I should take a look at the messages.
Member
Author
|
IMO the descriptive messages aren't adding much; in my view, they're a hack to use the variable more than useful text on their own. That's why I removed them here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #631.