luhn: Updated the exercise to the version 1.6.1#906
Merged
coriolinus merged 2 commits intoexercism:masterfrom Nov 15, 2019
Merged
luhn: Updated the exercise to the version 1.6.1#906coriolinus merged 2 commits intoexercism:masterfrom
coriolinus merged 2 commits intoexercism:masterfrom
Conversation
ZapAnton
force-pushed
the
update_luhn
branch
from
0095be1 to
c56c90a
Compare
ZapAnton
changed the title
ZapAnton
force-pushed
the
update_luhn
branch
from
c56c90a to
ae78e36
Compare
coriolinus
approved these changes
Nov 12, 2019
Member
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
Thanks for doing this work @ZapAnton!
We need to fix a few places where the exercise generator didn't do quite the right thing. Fixing the generator itself is a separate issue; for now, we just need to fix its output.
That said, I'm going to mark this approved for now on the assumption that fixing the output will be a quick thing. I intend to merge this on Friday or when the comments are fixed, whichever comes later.
petertseng
added
the
sync/tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant PRs: