rna-transcription: avoid using assert!(something().is_err())#972
Merged
coriolinus merged 1 commit intomasterfrom Oct 2, 2020
Merged
rna-transcription: avoid using assert!(something().is_err())#972coriolinus merged 1 commit intomasterfrom
coriolinus merged 1 commit intomasterfrom
Conversation
`assert!(something().is_err())` is an antipattern in testing because it hides the particular error, and most of the time that is undesired. It's better to expect a particular error result. This demonstrates better error-handling techniques for students.
petertseng
approved these changes
Oct 2, 2020
elektronaut0815
pushed a commit
to elektronaut0815/rust
that referenced
this pull request
Oct 2, 2020
…m#972) `assert!(something().is_err())` is an antipattern in testing because it hides the particular error, and most of the time that is undesired. It's better to expect a particular error result. This demonstrates better error-handling techniques for students.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assert!(something().is_err())is an antipattern in testing becauseit hides the particular error, and most of the time that is undesired.
It's better to expect a particular error result. This demonstrates
better error-handling techniques for students.