book-store: don't use std::mem::replace unnecessarily#977
Merged
coriolinus merged 1 commit intomasterfrom Oct 9, 2020
Merged
Conversation
At some point, std::mem::replace gained the `#[must_use]` attribute: if you don't use the previous value, there's no reason not to just assign to the target directly. This caused a warning to be emitted, which broke our check that no examples generate warnings. This PR fixes that. FWIW, I'm apparently to blame for the original use of mem::replace; at this remove, I have no idea what I was thinking then.
petertseng
approved these changes
Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point, std::mem::replace gained the
#[must_use]attribute:if you don't use the previous value, there's no reason not to just
assign to the target directly. This caused a warning to be emitted,
which broke our check that no examples generate warnings.
This PR fixes that.
FWIW, I'm apparently to blame for the original use of mem::replace;
at this remove, I have no idea what I was thinking then.