This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[Python] Add new concept exercise : numbers #2875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
authors & editor
exchange_test / exchange
Line 2 from .exchange import * -> from exchange import *
add config.json add testcase & test file
added : currency-exchange/.meta/example.py added : currency-exchange/.docs/instructions.md
* added design.md added : currency-exchange/.meta/design.md
Added hint.md (#8)
* Delete .DS_Store * Add : hint.md (#9) Add : hint.md Solving Conflict
fix exchangable to exchangeable fix "Chandler want" to "Chandler wants" in instructions.md
valentin-p
reviewed
Nov 29, 2020
valentin-p
reviewed
Nov 29, 2020
Contributor
|
Awesome. Thanks for the PR, it looks great. Couple of things:
That was my comments to help the PR be approved. I will let the maintainers add more comments if necessary. |
Contributor
Thanks for your feedback! We will review your feedback and revise it soon. |
BethanyG
reviewed
Dec 7, 2020
BethanyG
reviewed
Dec 7, 2020
languages/python/exercises/concept/currency-exchange/.docs/instructions.md
Outdated
Show resolved
Hide resolved
BethanyG
reviewed
Dec 7, 2020
languages/python/exercises/concept/currency-exchange/.docs/instructions.md
Outdated
Show resolved
Hide resolved
BethanyG
reviewed
Dec 7, 2020
languages/python/exercises/concept/currency-exchange/.docs/instructions.md
Outdated
Show resolved
Hide resolved
BethanyG
reviewed
Dec 7, 2020
languages/python/exercises/concept/currency-exchange/.docs/instructions.md
Outdated
Show resolved
Hide resolved
BethanyG
reviewed
Dec 7, 2020
languages/python/exercises/concept/currency-exchange/.docs/instructions.md
Outdated
Show resolved
Hide resolved
BethanyG
reviewed
Dec 7, 2020
languages/python/exercises/concept/currency-exchange/.docs/instructions.md
Outdated
Show resolved
Hide resolved
* Added new problem "Calculate unexchangeable value" Added modular arithmetic problem Calculate unexchangeable value * Added new problem "Calculate unexchangeable value" (example.py, exchange.py) Modified example.py, exchange.py * Modified Calculated unexchangeable value Modified `unexchangeable_value()` function's expected return type to be `int` * added new lines at the end of file * applied prettier on instructions.md Co-authored-by: Limm-jk <201602057@cs-cnu.org> Co-authored-by: Junkyu Lim <57378834+Limm-jk@users.noreply.github.com>
BethanyG
reviewed
Dec 12, 2020
we changed the concept name, so needed to update file.
BethanyG
reviewed
Dec 12, 2020
languages/python/exercises/concept/currency-exchange/.docs/introduction.md
Outdated
Show resolved
Hide resolved
BethanyG
reviewed
Dec 12, 2020
languages/python/exercises/concept/currency-exchange/.docs/introduction.md
Outdated
Show resolved
Hide resolved
BethanyG
reviewed
Dec 12, 2020
languages/python/exercises/concept/currency-exchange/.docs/introduction.md
Outdated
Show resolved
Hide resolved
BethanyG
reviewed
Dec 12, 2020
languages/python/exercises/concept/currency-exchange/.docs/introduction.md
Outdated
Show resolved
Hide resolved
OMEGA-Y
reviewed
Dec 12, 2020
languages/python/exercises/concept/currency-exchange/.docs/introduction.md
Outdated
Show resolved
Hide resolved
BethanyG
reviewed
Dec 12, 2020
…fig.json we've decided to name the stub and test files for the concept and not the story.
BethanyG
reviewed
Dec 12, 2020
languages/python/exercises/concept/currency-exchange/.meta/design.md
Outdated
Show resolved
Hide resolved
…ign.md minor typo
BethanyG
reviewed
Dec 12, 2020
languages/python/exercises/concept/currency-exchange/exchange_test.py
Outdated
Show resolved
Hide resolved
BethanyG
reviewed
Dec 12, 2020
languages/python/exercises/concept/currency-exchange/exchange_test.py
Outdated
Show resolved
Hide resolved
…roduction.md Co-authored-by: Yunseon Choi <science_co@naver.com>
BethanyG
approved these changes
Dec 12, 2020
BethanyG
reviewed
Dec 12, 2020
removed arithmetic as a concept until we get the about.md file made.
BethanyG
reviewed
Dec 12, 2020
…fig.json reverting file name change and deferring to different PR. This is currently breaking a CI test.
Member
|
Excellent work everyone! Thank you all for your time and effort. 🌟 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is our group's first contribution. We've created a new exercise about Concepts 'number'.(#2208)
I worked with OMEGA-Y / Yabby1997 / Ticktakto / wnstj2007
Any guidance is appreciated!