Revert "Fix compile error in circular buffer (#280)"#282
Closed
kahgoh wants to merge 1 commit intoexercism:mainfrom
Closed
Revert "Fix compile error in circular buffer (#280)"#282kahgoh wants to merge 1 commit intoexercism:mainfrom
kahgoh wants to merge 1 commit intoexercism:mainfrom
Conversation
This reverts commit 8f805f5. Just received notification that this has been fixed in the V compiler (see vlang/v#25645).
Contributor
|
I don't mind. We could replace the example solution with something like |
Member
Author
|
Happy to use one that completes in O(1), but there's something I am wondering about - which operation in the current example doesn't finish in O(1)? Is it the |
Member
Author
|
I think I'll close this PR without merging. I don't think the change is important as the example only serves to show the exercise can be solved in V and isn't really end user facing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 8f805f5 for #277.
The reason for this is because I just received notification that this has been fixed in the V compiler (see vlang/v#25645 and vlang/v#25585).
Feel free to close this PR without merging if you feel we should keep the fix that was added instead.