exercises(pangram): test more non-alphanumeric printable ASCII#361
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
Somewhat similar test cases were rejected or removed upstream in the past:
However, in this case I'm inclined to merge. It's true that the existing non-alphanumeric printable ASCII characters in the tests are sufficiently close to |
This test checks that the submitted solution does not panic on non-alphanumeric input.
Faulty solution 'from the wild' that is caught by this test but not by the others:
There are no test cases in
problem-specificationsthat could be pulled in to the same effect. I will not myself pursue upstreaming intoproblem-specifications.