zoneName/zoneEndpoint caching for v3 client #733
Draft
+60
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we migrated cli to egoscale v3, we just replaced calls 1-1. This gives us multiple GetZoneAPIEndpoint calls (which trigger list-zones endpoint) in some cases:
after resource update we call Show which has it's own GetZoneAPIEndpoint;
in list resources we call GetZoneAPIEndpoint for each zone.
To avoid refactoring the large portion of CLI code, we can instead make GetZoneAPIEndpoint from egoscale call list-zones only once and cache result (list of zones is practically static).
Checklist
(For exoscale contributors)