[Qt][Wallet] Cleanup branding for XP#1
Closed
JSKitty wants to merge 1 commit into
Closed
Conversation
Branding within both the code and Qt GUI has been further branded for eXperience Points rather than our ancestor; PIVX. No breaking changes were done, simply a cleanup of the branding, and a placeholder QT Green theme, which fits XP better than PIVX, but is by no means a permanent GUI theme.
eXperience-Points
pushed a commit
that referenced
this pull request
May 29, 2020
…filterAcceptsRow 359f70e [GUI] Explicit cast from quint32 to bool in filterAcceptsRow (random-zebra) Pull request description: This is a (hopefully definitive) fix for a strange segfault I was consistently having on testnet with the GUI wallet (during the loading of the stake charts), with the following stacktrace ``` #0 0x00007ffff58363bb in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #1 0x00007ffff583b25d in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #2 0x00007ffff583b932 in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #3 0x00007ffff583bca9 in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #4 0x00007ffff583c50a in QSortFilterProxyModel::invalidateFilter() () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #5 0x00005555556aa809 in DashboardWidget::updateStakeFilter() (this=this@entry=0x5555577817d0) at qt/pivx/dashboardwidget.cpp:480 PIVX-Project#6 0x00005555556ac736 in DashboardWidget::getAmountBy() (this=this@entry=0x5555577817d0) at qt/pivx/dashboardwidget.cpp:503 PIVX-Project#7 0x00005555556ad1a1 in DashboardWidget::loadChartData(bool) (this=this@entry=0x5555577817d0, withMonthNames=false) at qt/pivx/dashboardwidget.cpp:556 PIVX-Project#8 0x00005555556ad703 in DashboardWidget::run(int) (this=0x5555577817d0, type=<optimized out>) at qt/pivx/dashboardwidget.cpp:812 PIVX-Project#9 0x00005555557641d4 in Worker::process() (this=0x5555576314c0) at qt/pivx/loadingdialog.cpp:12 PIVX-Project#10 0x00007ffff56932b2 in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 PIVX-Project#11 0x00007ffff569617d in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 PIVX-Project#12 0x00007ffff4ae36db in start_thread (arg=0x7ffe61ffb700) at pthread_create.c:463 PIVX-Project#13 0x00007ffff2c9e88f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95 ``` Explicit the cast to bool when checking the transaction type in `TransactionFilterProxy::filterAcceptsRow`. ACKs for top commit: furszy: detective work 👍 , utACK 359f70e. Fuzzbawls: utACK 359f70e then Tree-SHA512: f1481a0545fb1ebe62b28232f9257e6c52306ff15dd1dcefc29d4eeb3dd25b7231d48416cad528e720fb68aa192b089e14bfc8ee92e55406ea02fc777f552b15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branding within both the code and Qt GUI has been further branded for eXperience Points rather than our ancestor; PIVX. No breaking changes were done, simply a cleanup of the branding, and a placeholder QT Green theme, which fits XP better than PIVX, but is by no means a permanent GUI theme.
The new (placeholder) QT Theme is attached in a gif below (Mind the quality, it looks better in-person):
PIVX-based file names and makefiles have not been touched, as I wanted to keep this PR clean without causing any conflicts due to filename changes.
This PR was lightly tested on Ubuntu 16.04 64bit.