Fix appearance changed into wrong activity#34
Merged
Kudo merged 1 commit intoexp-latestfrom Jan 23, 2024
Merged
Conversation
alanjhughes
approved these changes
Jan 23, 2024
Kudo
deleted the
@kudo/eng-11171-appearance-setcolorscheme-does-not-work-on-android
branch
2 tasks
Kudo
added a commit
to expo/expo
that referenced
this pull request
Jan 23, 2024
# Why fixes #26556 fixes #26561 close ENG-11171 close ENG-11173 # How - the #26556 appearance issue was resolved by expo/react-native#34. i've cherry-picked the fix to both sdk-49 and sdk-50 branch of react-native-lab fork. - the #26561 was coming from incompatible fresco versions. since fresco was bumped from react-native 0.73, we should re-version sdk-49 aar with new fresco. here's what i did # Test Plan tested on the local versioned release build expo-go - #26556 for both sdk-49 and sdk-50 - #26561 doesn't have a repro but i can copy a repro from https://github.com/jobtoday/react-native-image-viewing/tree/master/example
gabrieldonadel
pushed a commit
that referenced
this pull request
Mar 13, 2024
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
alanjhughes
pushed a commit
that referenced
this pull request
Jun 4, 2024
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Aug 5, 2024
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Aug 22, 2024
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Aug 12, 2025
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Aug 15, 2025
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Aug 27, 2025
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Sep 9, 2025
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Sep 10, 2025
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Sep 10, 2025
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Sep 23, 2025
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Sep 30, 2025
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Oct 8, 2025
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
alanjhughes
pushed a commit
that referenced
this pull request
Oct 21, 2025
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Oct 21, 2025
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Dec 8, 2025
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Dec 11, 2025
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Dec 18, 2025
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Feb 10, 2026
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Feb 11, 2026
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Feb 11, 2026
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel
pushed a commit
that referenced
this pull request
Feb 27, 2026
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
fixes expo/expo#26556
close ENG-11171
How
the original
AppCompatDelegate.setDefaultNightMode()is a global setup. when changing the night mode, it will actually call HomeActivity'sonConfigurationChanged. this pr tries to set night mode to current activity by using thesetLocalNightMode()Test Plan
unversioned expo-go with repro from expo/expo#26556