fix: correctly run .matches when passing regex object#1156
Merged
fedeci merged 2 commits intoexpress-validator:masterfrom Jun 19, 2022
tonysamperi:bugfix/regex-instance
Merged
fix: correctly run .matches when passing regex object#1156fedeci merged 2 commits intoexpress-validator:masterfrom tonysamperi:bugfix/regex-instance
fedeci merged 2 commits intoexpress-validator:masterfrom
tonysamperi:bugfix/regex-instance
Conversation
Member
|
Merging and publishing this tomorrow morning! Sorry again for the delay! |
This was referenced Sep 8, 2024
This was referenced Sep 11, 2024
This was referenced Sep 13, 2024
This was referenced Sep 14, 2024
This was referenced Sep 19, 2024
This was referenced Sep 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forcing pattern to be string, to cope with lib validator which doesn't reset the RegExp instance
Fixes #1127
Workaround of a behaviour which should be fixed in validator.js
To-do list