Skip to content

Follow standard style in readme#93

Merged
troygoode merged 1 commit intoexpressjs:masterfrom
LinusU:patch-1
Dec 29, 2016
Merged

Follow standard style in readme#93
troygoode merged 1 commit intoexpressjs:masterfrom
LinusU:patch-1

Conversation

@LinusU
Copy link
Copy Markdown
Member

@LinusU LinusU commented Nov 7, 2016

@LinusU
Copy link
Copy Markdown
Member Author

LinusU commented Dec 21, 2016

@crandmck Should I merge these or should someone else look at them? :)

@crandmck
Copy link
Copy Markdown
Member

Changes LGTM, so you can merge as far as I'm concerned. :-)

@LinusU
Copy link
Copy Markdown
Member Author

LinusU commented Dec 22, 2016

Great :)

@LinusU
Copy link
Copy Markdown
Member Author

LinusU commented Dec 22, 2016

Hmm, actually I don't seem to have write permissions on this repository... I do t know I'm supposed to though :)

Could you merge it for me?

@crandmck
Copy link
Copy Markdown
Member

Lol, I don't have rights either... @dougwilson shouldn't TC members be able to merge PRs?

@dougwilson
Copy link
Copy Markdown
Contributor

So this is a module from @troygoode who moved it into the expressjs organization some time ago. We have never really sat down to decide what it means to move an external project into the expressjs organization before, and of course, how any new rules would apply retroactively. I would probably not want to do anything immediately right now, at least without even hearing from @troygoode on the subject :)

@troygoode what do you think about this all? So far this module has been autonomous within the expressjs organization. We're probably going to have a discussion on this in the coming weeks and would love it if you could participate :) The best date / time would just be the next TC meeting, which is Jan 11 at 23:30 UTC.

@crandmck
Copy link
Copy Markdown
Member

crandmck commented Dec 28, 2016

Yes, discussing in the TC makes sense. Thanks for clarification @dougwilson.

BTW, since a lot of folks are out due to the holidays (and based on your comment above), I'm assuming that there won't be a TC meeting today (which there normally would be on the biweekly schedule). I'll add a short note in the discussions repo just to be explicit.

@troygoode
Copy link
Copy Markdown
Member

Hi @dougwilson I'm happy to participate in the upcoming TC and more than willing to make adjustments that bring cors further into the expressjs standard. Looking at this PR now.

@troygoode troygoode merged commit b6dac7f into expressjs:master Dec 29, 2016
@troygoode
Copy link
Copy Markdown
Member

@LinusU @dougwilson I've merged this one and also updated the repo's settings to give the express-tc team Admin access (patterned after the settings in expressjs/express)

@LinusU
Copy link
Copy Markdown
Member Author

LinusU commented Dec 30, 2016

Thank you ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants