handle 405

[wangfengming]

How to handle 405?
Here is a simple way:

insert the code on https://github.com/expressjs/express/blob/master/lib/router/index.js#L253

        if (method !== 'OPTIONS') req.notAllowedRoute = route

then I can handle 405 by:

const notAllowedHandler = (req, res, next) => {
    if (req.notAllowedRoute) {
        res.header('Allow', Object.keys(req.notAllowedRoute.methods).join(', ').toUpperCase())
        res.status(405)
    } else {
        next()
    }
}

[wesleytodd]

Hi @wangfengming. Does this conversation help you? pillarjs/router#62

[wangfengming]

It means I need to handle 405 per every route?

[wesleytodd]

Currently yes. The solution you propose is rather complicated for the router to make assumptions about because of the shear number of combinations the current api supports. Away from my computer right now, but I can try to outline some of what I mean when I get back to one.

[wangfengming]

If Router can store the "only matched path route" and/or "matched path and method route" on req, then I can handle 405 with minimal code.

Sorry for my poor english. 😂

[wesleytodd]

Your english is not poor 😀

Later tonight Ill write some examples of edge cases and why I think it is not that simple.

[wangfengming]

It seems that pillarjs/router#34 and pillarjs/router#56 are on the same topic. 🤔

[wesleytodd]

I think both of these are generic avenues for achieving the end goal you want. If we go one of those directions then it supersedes this issue. @wangfengming maybe you could comment over there to put pressure on moving those forward?

[gajananpp]

PR #2703 is already opened which allows router and route to be configured for automatically responding with status 405 and is added to 4.17 milestone 👍

[mastermatt]

I'm going to close this as it seems to be answered/resolved and hasn't had any activity in over a year.